Fix logging without a tty #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes logging without an iteractive session, e.g. docker without -it or by default on k8s. The issue there is that without explicitly adding handlers without a tty the log are not sent to stderr. Also we need to take care of the propagation in case the OTel Logging handler is configured on the root logger to have also these logs exported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This fixes logging without an iteractive session, e.g. docker without -it or by default on k8s.
The issue there is that without explicitly adding handlers without a tty the log are not sent to stderr.
Also we need to take care of the propagation in case the OTel Logging handler is configured on the root logger to have also these logs exported.
Related issues
Closes #435