Skip to content

Ensure errors from boolean flags in CLI are managed #3008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −5
Open

Ensure errors from boolean flags in CLI are managed #3008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions cmd/edit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,15 @@ func editDashboardsCmd(cmd *cobra.Command, args []string) error {
common.TrimStringSlice(dashboardIDs)

var opts []kibana.ClientOption
tlsSkipVerify, _ := cmd.Flags().GetBool(cobraext.TLSSkipVerifyFlagName)
tlsSkipVerify, err := cmd.Flags().GetBool(cobraext.TLSSkipVerifyFlagName)
if err != nil {
return cobraext.FlagParsingError(err, cobraext.TLSSkipVerifyFlagName)
}
if tlsSkipVerify {
opts = append(opts, kibana.TLSSkipVerify())
}

allowSnapshot, _ := cmd.Flags().GetBool(cobraext.AllowSnapshotFlagName)
allowSnapshot, err := cmd.Flags().GetBool(cobraext.AllowSnapshotFlagName)
if err != nil {
return cobraext.FlagParsingError(err, cobraext.AllowSnapshotFlagName)
}
Expand Down
5 changes: 4 additions & 1 deletion cmd/export_dashboards.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ func exportDashboardsCmd(cmd *cobra.Command, args []string) error {
common.TrimStringSlice(dashboardIDs)

var opts []kibana.ClientOption
tlsSkipVerify, _ := cmd.Flags().GetBool(cobraext.TLSSkipVerifyFlagName)
tlsSkipVerify, err := cmd.Flags().GetBool(cobraext.TLSSkipVerifyFlagName)
if err != nil {
return cobraext.FlagParsingError(err, cobraext.TLSSkipVerifyFlagName)
}
if tlsSkipVerify {
opts = append(opts, kibana.TLSSkipVerify())
}
Expand Down
5 changes: 4 additions & 1 deletion cmd/export_ingest_pipelines.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@ func exportIngestPipelinesCmd(cmd *cobra.Command, args []string) error {
common.TrimStringSlice(pipelineIDs)

var opts []elasticsearch.ClientOption
tlsSkipVerify, _ := cmd.Flags().GetBool(cobraext.TLSSkipVerifyFlagName)
tlsSkipVerify, err := cmd.Flags().GetBool(cobraext.TLSSkipVerifyFlagName)
if err != nil {
return cobraext.FlagParsingError(err, cobraext.TLSSkipVerifyFlagName)
}
if tlsSkipVerify {
opts = append(opts, elasticsearch.OptionWithSkipTLSVerify())
}
Expand Down
5 changes: 4 additions & 1 deletion cmd/install.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,10 @@ func installCommandAction(cmd *cobra.Command, _ []string) error {
}

var opts []kibana.ClientOption
tlsSkipVerify, _ := cmd.Flags().GetBool(cobraext.TLSSkipVerifyFlagName)
tlsSkipVerify, err := cmd.Flags().GetBool(cobraext.TLSSkipVerifyFlagName)
if err != nil {
return cobraext.FlagParsingError(err, cobraext.TLSSkipVerifyFlagName)
}
if tlsSkipVerify {
opts = append(opts, kibana.TLSSkipVerify())
}
Expand Down