Skip to content

Using matching docker container server version in unit tests #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 14, 2024
Merged

Using matching docker container server version in unit tests #904

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2e064f6
unit test container version latest
l-trotta Nov 13, 2024
6d037ac
fetching version info from artifacts api
l-trotta Nov 14, 2024
3f0d1f1
using io utils also for writing
l-trotta Nov 14, 2024
dabbbce
Merge branch 'main' into using-updated-container-version
l-trotta Nov 14, 2024
c169396
checkstyle
l-trotta Nov 14, 2024
2215613
Merge remote-tracking branch 'origin/using-updated-container-version'…
l-trotta Nov 14, 2024
943a758
Merge branch 'main' into using-updated-container-version
l-trotta Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions java-client/src/test/java/co/elastic/clients/elasticsearch/ElasticsearchTestServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,17 @@ public synchronized ElasticsearchTestServer start() {
return this;
}

Version version = Version.VERSION.major() < 8 ? new Version(7,17,5,false) : new Version(8,12,0,false);
// using latest snapshot version for generic tests
Version version = Version.VERSION.major() < 8 ? new Version(7, 17, 25, false) :
Version.parse(Version.VERSION.major() + "." + Version.VERSION.minor() + ".0-SNAPSHOT");

// Note we could use version.major() + "." + version.minor() + "-SNAPSHOT" but plugins won't install on a snapshot version
String esImage = "docker.elastic.co/elasticsearch/elasticsearch:" + version;
// using specific stable version for tests with plugins
if (plugins.length > 0) {
version = Version.VERSION.major() < 8 ? new Version(7, 17, 25, false) : new Version(8, 16, 0, false);
}

String esImage = "docker.elastic.co/elasticsearch/elasticsearch:" + version;

DockerImageName image;
if (plugins.length == 0) {
image = DockerImageName.parse(esImage);
Expand Down
Loading