Making variant tag more lenient #936
Merged
+102
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2025
* lifecycle response fix * checkstyle * update test * cleaner code
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2025
* lifecycle response fix * checkstyle * update test * cleaner code
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2025
* lifecycle response fix * checkstyle * update test * cleaner code
l-trotta
added a commit
that referenced
this pull request
Feb 17, 2025
* lifecycle response fix * checkstyle * update test * cleaner code Co-authored-by: Laura Trotta <[email protected]>
l-trotta
added a commit
that referenced
this pull request
Feb 17, 2025
* lifecycle response fix * checkstyle * update test * cleaner code Co-authored-by: Laura Trotta <[email protected]>
l-trotta
added a commit
that referenced
this pull request
Feb 17, 2025
* lifecycle response fix * checkstyle * update test * cleaner code Co-authored-by: Laura Trotta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some variant tags can be boolean, like
managedinExplainLifecycleResponse. Adding boolean handling to json deserializers look ahead methods. Fixes #312, fixes #882 .Everything works, except for the fact that the roundtrip doesn't work: "managed" gets ignored by deserialization.