Run tests in non-strict JSON mode, like real applications #942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swallez
added
Category: Enhancement
l-trotta
approved these changes
Feb 21, 2025
swallez
added a commit
that referenced
this pull request
Feb 21, 2025
Co-authored-by: Sylvain Wallez <[email protected]>
swallez
added a commit
that referenced
this pull request
Feb 21, 2025
Co-authored-by: Sylvain Wallez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON mappers used in tests are in strict mode and will reject unknown fields when deserializing objects. This was useful in the early days of the Java Client when the API spec was still in flux. We now have extensive validation for the API spec that catches these unknown fields.
This PR removes strict mode from test JSON mappers, so that they behave like regular applications.