Skip to content

Conversation

colleenmcginnis
Copy link
Contributor

Adds the new docs CI checks. This will enable a preview to build our new Markdown-based docs.

Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions, but if those aren't things we need to worry about then LGTM!

docs-preview:
uses: elastic/docs-builder/.github/workflows/preview-build.yml@main
with:
path-pattern: docs/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we ignore docs/doc_examples here since those are all code snippets?

@marciw marciw merged commit 7449adb into elastic:main Feb 26, 2025
23 checks passed
marciw pushed a commit to colleenmcginnis/elasticsearch-js that referenced this pull request Feb 27, 2025
marciw added a commit that referenced this pull request Feb 27, 2025
* delete asciidoc files

* add migrated files

* Apply suggestions from review

Co-authored-by: Josh Mock <[email protected]>

* Apply suggestions from review

Co-authored-by: Josh Mock <[email protected]>

* add the new ci checks (#2634)

---------

Co-authored-by: Marci W <[email protected]>
Co-authored-by: Josh Mock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants