Skip to content

Conversation

colleenmcginnis
Copy link
Contributor

Fixes image paths to work with docs-assembler.

Notes for the reviewer:

  • I was not able to get images in reference, extend, or release-notes to work using the :::{image} syntax because it seems to resolve differently than the Markdown ![]() syntax. We should address this in docs-builder, but in order to get images working as soon as possible, I've used Markdown syntax and left us a TO DO in a code comment to add back the screenshot class where applicable.
  • Can you please add the appropriate labels needed for backporting?

@colleenmcginnis colleenmcginnis enabled auto-merge (squash) April 16, 2025 16:14
@JoshMock JoshMock disabled auto-merge April 16, 2025 17:16
@JoshMock
Copy link
Member

I still need to fix my required checks rules so PRs can auto-merge when unit tests are skipped. 🤦

In the meantime, I have to bypass and admin-merge.

@JoshMock JoshMock merged commit c3f987c into elastic:main Apr 16, 2025
10 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 16, 2025
Co-authored-by: Josh Mock <[email protected]>
(cherry picked from commit c3f987c)
@colleenmcginnis colleenmcginnis deleted the fix-images-when-assembled branch April 16, 2025 17:18
JoshMock added a commit that referenced this pull request Apr 16, 2025
Co-authored-by: Josh Mock <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants