Skip to content

Conversation

jerinthomascarmel
Copy link

@jerinthomascarmel jerinthomascarmel commented Jun 15, 2025

Fix header merge logic to preserve default headers when custom headers are provided

Changes:
Update header-merge logic to explicitly spread default headers and then apply opts.headers, ensuring defaults are preserved.

Closes: #2862

Testing:
Run npm test to ensure the new header-merge test passes.

Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
1dc54bb

Please, read and sign the above mentioned agreement if you want to contribute to this project

@prodsecmachine
Copy link

prodsecmachine commented Jun 15, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@JoshMock
Copy link
Member

JoshMock commented Jul 2, 2025

Closing in favor of #2890 which has unit tests, solves for more than one case, and does not need to wait for a CLA agreement to be signed.

@JoshMock JoshMock closed this Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom headers erases all header defaults rather than merging the two

3 participants