TOPIC: Parsing PDFs table contents for RAG supporting notebook #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated readme.md to include example of fetch surrounding chunks
|
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/341 |
updated file names
removed colab link to check if that is why build is faling.
adding pdf to branch
per instructions here: https://github.com/elastic/elasticsearch-labs/blob/main/CONTRIBUTING.md#automated-testing I fixed the notebook and the local test passed. ```*[sunman][~/Documents/GitHub/elasticsearch-labs]$ bin/nbtest supporting-blog-content/alternative-approach-for-parsing-pdfs-in-rag/alternative-approach-for-parsing-pdfs-in-rag.ipynb Running supporting-blog-content/alternative-approach-for-parsing-pdfs-in-rag/alternative-approach-for-parsing-pdfs-in-rag.ipynb... OK ```
created readme.md
Contributor
|
LGTM. @justincastilla do you mind giving this a once over for me? |
Contributor
|
On it! |
supporting-blog-content/alternative-approach-for-parsing-pdfs-in-rag/README.md
Show resolved
Hide resolved
supporting-blog-content/alternative-approach-for-parsing-pdfs-in-rag/README.md
Show resolved
Hide resolved
justincastilla
requested changes
Oct 17, 2024
Contributor
justincastilla
left a comment
justincastilla
left a comment
There was a problem hiding this comment.
Just a couple usability things I thought of that might make running this notebook more efficient for the user.
Co-authored-by: Justin Castilla <[email protected]>
added suggestions based on PR comments/review.
Added comments per slack discussion: https://elastic.slack.com/archives/C059SNT4X0R/p1729261191648229
Contributor
Author
|
@carlyrichmond can this be merged and closed? |
Contributor
Author
|
@carlyrichmond - Merging is blocked. All checks have passed. |
carlyrichmond
approved these changes
Feb 20, 2025
Contributor
@sunilemanjee I see outstanding changes requested from @justincastilla. Have these been addressed? |
…nt Retrieval notebook First commit of Unifying Elastic Vector Database and LLMs for Intelligent Retrieval notebook. Passed local nbtest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This notebook is supporting article: https://github.com/elastic/search-labs-elastic-co/pull/1270