Use published images in chatbot-rag-app example #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
commented
Feb 13, 2025
|
|
||
| ```bash | ||
| docker compose up --build --force-recreate | ||
| docker compose up --force-recreate |
Collaborator
Author
There was a problem hiding this comment.
I considered --pull always for reproducibility but figured the simpler command is better
Contributor
There was a problem hiding this comment.
agreed in principal, but --force-recreate is already there, too. I think we should do --pull-always until the telemetry stuff settles down, so that a future blog won't result in someone retrying and not seeing the new stuff. I know it may be overly cautious, so not hard opinion on this.
Collaborator
Author
There was a problem hiding this comment.
Yeah given possible telemetry churn makes sense, added it
anuraaga
commented
Feb 13, 2025
codefromthecrypt
approved these changes
Feb 13, 2025
Contributor
codefromthecrypt
left a comment
codefromthecrypt
left a comment
There was a problem hiding this comment.
editorial only. LGTM
Co-authored-by: Adrian Cole <[email protected]>
Co-authored-by: Adrian Cole <[email protected]>
6 tasks
Contributor
|
thx again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the published image to the chatbot-rag-app docker-compose. It's used by default if
--buildisn't passed.