-
Notifications
You must be signed in to change notification settings - Fork 253
Add Elasticsearch ChatGPT connector content #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Elasticsearch ChatGPT connector content #505
Conversation
Adds support files for Elasticsearch ChatGPT connector blog content, including Jupyter notebook and dataset for demonstrations and examples.
|
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/505 |
|
Hi @TomasMurua, thank you for your submission. We appreciate it. Here are a few pointers to address:
cc: @carlyrichmond |
Hi @someshwaranM All comments have been addressed. Thanks for the quick review! |
|
Hi @TomasMurua, thank you. Will keep you posted. |
someshwaranM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TomasMurua, the colab code looks good to me and the documentation is aligned with our discussion. I tested and it works.
cc: @carlyrichmond, I’d like to run it through you finally, could you take a look and help get it approved/merged? Thanks in advance!
|
Except the ngrok tunnel step, for which I'm getting a weird auth error, everything seems to be running and behaving as expected. I would probably recommend a couple of things:
Aside from that it's good to go. Hope that helps! |
|
Hi @someshwaranM and @carlyrichmond, I've addressed all the latest feedback. Everything should be ready now. Thanks for the quick reviews! |
Adds support files for Elasticsearch ChatGPT connector blog content, including Jupyter
notebook and dataset for demonstrations and examples.