Skip to content

Conversation

@TomasMurua
Copy link
Contributor

Adds support files for Elasticsearch ChatGPT connector blog content, including Jupyter
notebook and dataset for demonstrations and examples.

  Adds support files for Elasticsearch ChatGPT connector blog content, including Jupyter
  notebook and dataset for demonstrations and examples.
@gitnotebooks
Copy link

gitnotebooks bot commented Nov 10, 2025

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/505

@someshwaranM
Copy link

Hi @TomasMurua, thank you for your submission. We appreciate it.

Here are a few pointers to address:

  • Per the contributing guidelines, filenames should follow the kebab-case convention. For example: elasticsearch-mcp-server-for-chatgpt.ipynb rather than the current name with spaces or underscores (supporting-blog-content/elasticsearch-chatgpt-connector/Elasticsearch MCP Server for ChatGPT.ipynb).

  • Please add a introductory description or agenda in the first cell summarizing the purpose of the notebook, bullet points are perfectly fine.

  • For each code cell, include a brief description at the top (# what this cell does) to explain its purpose rather than relying solely on headers.

  • Please preserve the notebook outputs so users can view the example results directly.

cc: @carlyrichmond

@someshwaranM someshwaranM self-requested a review November 13, 2025 04:51
@TomasMurua
Copy link
Contributor Author

Hi @TomasMurua, thank you for your submission. We appreciate it.

Here are a few pointers to address:

  • Per the contributing guidelines, filenames should follow the kebab-case convention. For example: elasticsearch-mcp-server-for-chatgpt.ipynb rather than the current name with spaces or underscores (supporting-blog-content/elasticsearch-chatgpt-connector/Elasticsearch MCP Server for ChatGPT.ipynb).
  • Please add a introductory description or agenda in the first cell summarizing the purpose of the notebook, bullet points are perfectly fine.
  • For each code cell, include a brief description at the top (# what this cell does) to explain its purpose rather than relying solely on headers.
  • Please preserve the notebook outputs so users can view the example results directly.

cc: @carlyrichmond

Hi @someshwaranM All comments have been addressed. Thanks for the quick review!

@someshwaranM
Copy link

Hi @TomasMurua, thank you. Will keep you posted.

Copy link

@someshwaranM someshwaranM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TomasMurua, the colab code looks good to me and the documentation is aligned with our discussion. I tested and it works.

cc: @carlyrichmond, I’d like to run it through you finally, could you take a look and help get it approved/merged? Thanks in advance!

@carlyrichmond
Copy link
Contributor

Except the ngrok tunnel step, for which I'm getting a weird auth error, everything seems to be running and behaving as expected. I would probably recommend a couple of things:

  1. Consider adding requirements.txt to make managing the versions easier with venv.
  2. Add a small screenshot showing the interactivity in ChatGPT.

Aside from that it's good to go. Hope that helps!

@TomasMurua
Copy link
Contributor Author

Hi @someshwaranM and @carlyrichmond,

I've addressed all the latest feedback.

Everything should be ready now. Thanks for the quick reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants