Skip to content

Remove unnecessary override code #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Remove unnecessary override code #2695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eeeab7
Remove unnecessary override code
daixque Nov 11, 2024
fd9c24a
Apply lint
daixque Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions elasticsearch/helpers/vectorstore/_async/vectorstore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,11 @@ def __init__(
# client.options preserves existing (non-user-agent) headers.
client = client.options(headers={"User-Agent": user_agent})

if hasattr(retrieval_strategy, "text_field"):
if (
hasattr(retrieval_strategy, "text_field")
and retrieval_strategy.text_field is None
):
retrieval_strategy.text_field = text_field
if hasattr(retrieval_strategy, "vector_field"):
retrieval_strategy.vector_field = vector_field

self.client = client
self.index = index
Expand Down
7 changes: 4 additions & 3 deletions elasticsearch/helpers/vectorstore/_sync/vectorstore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,11 @@ def __init__(
# client.options preserves existing (non-user-agent) headers.
client = client.options(headers={"User-Agent": user_agent})

if hasattr(retrieval_strategy, "text_field"):
if (
hasattr(retrieval_strategy, "text_field")
and retrieval_strategy.text_field is None
):
retrieval_strategy.text_field = text_field
if hasattr(retrieval_strategy, "vector_field"):
retrieval_strategy.vector_field = vector_field

self.client = client
self.index = index
Expand Down
Loading