Skip to content

Simplify lint and format nox sessions #2790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Simplify lint and format nox sessions #2790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 2 additions & 31 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ def format(session):
session.run("black", *SOURCE_FILES)
session.run("python", "utils/license-headers.py", "fix", *SOURCE_FILES)

lint(session)


@nox.session()
def lint(session):
Expand All @@ -106,8 +104,7 @@ def lint(session):

session.install(".[async,requests,orjson,pyarrow,vectorstore_mmr]", env=INSTALL_ENV)

# Run mypy on the package and then the type examples separately for
# the two different mypy use-cases, ourselves and our users.
# Run mypy on the package, the type examples and the DSL examples
session.run(
"mypy",
"--strict",
Expand All @@ -116,28 +113,7 @@ def lint(session):
"--show-error-codes",
"--enable-error-code=ignore-without-code",
"elasticsearch/",
)
session.run(
"mypy",
"--strict",
"--show-error-codes",
"test_elasticsearch/test_types/sync_types.py",
)
session.run(
"mypy",
"--strict",
"--show-error-codes",
"test_elasticsearch/test_types/async_types.py",
)

# check typing on the DSL examples
session.run(
"mypy",
"--strict",
"--implicit-reexport",
"--explicit-package-bases",
"--show-error-codes",
"--enable-error-code=ignore-without-code",
"test_elasticsearch/test_types/",
"examples/dsl/",
)

Expand All @@ -151,11 +127,6 @@ def lint(session):
"--explicit-package-bases",
"--show-error-codes",
"elasticsearch/",
)
session.run(
"mypy",
"--strict",
"--show-error-codes",
"test_elasticsearch/test_types/sync_types.py",
)

Expand Down
Loading