Skip to content

Conversation

pquentin
Copy link
Member

No description provided.

Copy link

github-actions bot commented Sep 24, 2025

🔍 Preview links for changed docs

@pquentin pquentin marked this pull request as ready for review September 24, 2025 14:42
@pquentin pquentin changed the title Support trio with httpx Support Trio with httpx Sep 25, 2025
pyproject.toml Outdated
dependencies = [
"elastic-transport>=9.1.0,<10",
# TODO revert before merging/releasing
"elastic-transport @ git+https://github.com/pquentin/elastic-transport-python.git@trio-support",
Copy link
Contributor

@miguelgrinberg miguelgrinberg Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a comment here just to remind you that need this to be edited. (not sure if your TODO comment triggers some alert or linter...)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There's no alert or linter, no.

Copy link
Contributor

@miguelgrinberg miguelgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor/optional comments and suggestions, but overall LGTM.

@miguelgrinberg miguelgrinberg merged commit 419c1ff into elastic:main Oct 20, 2025
15 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 20, 2025
* Support trio with httpx

* Fix lint

* Stop trying to run clients tests twice in a row

* Remove anyio from runtime dependencies

* Use custom _sleep function

* Stop pretending that we want/can run YAML test with both trio and asyncio

* Document Trio support

* Remove debug print

* Remove useless anyio fixture

* Handle more markers

* Fix references to asyncio

* Use anyio for bulk flush timeout

* linter fixes

* revert pyproject.toml to official transport releases

---------

Co-authored-by: Miguel Grinberg <[email protected]>
(cherry picked from commit 419c1ff)
miguelgrinberg added a commit that referenced this pull request Oct 20, 2025
* Support trio with httpx

* Fix lint

* Stop trying to run clients tests twice in a row

* Remove anyio from runtime dependencies

* Use custom _sleep function

* Stop pretending that we want/can run YAML test with both trio and asyncio

* Document Trio support

* Remove debug print

* Remove useless anyio fixture

* Handle more markers

* Fix references to asyncio

* Use anyio for bulk flush timeout

* linter fixes

* revert pyproject.toml to official transport releases

---------


(cherry picked from commit 419c1ff)

Co-authored-by: Quentin Pradet <[email protected]>
Co-authored-by: Miguel Grinberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants