Skip to content

Conversation

picandocodigo
Copy link
Member

No description provided.

Copy link

github-actions bot commented Jul 16, 2025

🔍 Preview links for changed docs

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I made minor suggestions for clarity and style.

@picandocodigo
Copy link
Member Author

Thank you @marciw! I included all of your suggestions. I kept the capitalized name since that's the product name (it's the same in its own README). I also modified the text on the last line since I want to explicitly let users know they don't need to use the official Elasticsearch client with this tool:

- The `elastic-esql` library works independently of the {{es}} client, so you can use it alongside any client — not just Ruby.
+ The `elastic-esql` library works independently of the {{es}} client, so you can use it alongside any client — not just `elasticsearch-ruby` .

Let me know what you think, thanks!

Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me to be specific about the client! I noticed an extra space but otherwise LGTM.

@picandocodigo
Copy link
Member Author

Thank you @pquentin @marciw 👍

@picandocodigo picandocodigo merged commit d7d3818 into main Jul 18, 2025
17 checks passed
@picandocodigo picandocodigo deleted the docs_esql branch July 18, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants