-
Notifications
You must be signed in to change notification settings - Fork 115
Break function_score out into single- and multi-function types #2852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
I'm not entirely sure |
pquentin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
Laura plans to take more time to review this.
|
we need to rename FunctionScoreContainer, the java generator (and maybe others?) removes the "Container" part of the name, and since FunctionScore already exists there's a duplicate error. Does FunctionScoreCommonContainer sounds okay? Or renaming FunctionScore back to FunctionScoreQuery as is was before - feels weird being the only Query field that is not called SomethingQuery. |
|
After discussing it with the other static clients maintainer we have decided that supporting this would require too much effort compared to the benefits (since it's not a unique feature, but just an alternative syntax). If we were to discover a case where this is absolutely necessary to implement in the dynamic clients then we can review this solution again as a starting point and the static client can ignore it from the generator. |
|
Thanks @l-trotta! |
Fixes #2109.