Skip to content

Fix download-artifacts on main branch #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2024
Merged

Fix download-artifacts on main branch #2972

merged 1 commit into from
Oct 2, 2024

Conversation

@pquentin
Copy link
Member

@pquentin pquentin commented Oct 1, 2024

The Artifacts Snapshot API still uses 'master'. I forgot to test #2949 on main. Here's how to do it:

make setup
npm install .github/download-artifacts
node .github/download-artifacts/index.js --branch main
make contrib
git status

@pquentin
Fix download-artifacts on main branch
a4a6233 
The Artifacts Snapshot API still uses 'master'.
@pquentin pquentin requested review from JoshMock and l-trotta October 1, 2024 10:41
@pquentin pquentin mentioned this pull request Oct 1, 2024
Merged
@pquentin pquentin merged commit f781f99 into main Oct 2, 2024
6 checks passed
@pquentin pquentin deleted the fetch-artifacts-main branch October 2, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshMock JoshMock JoshMock approved these changes

@flobernd flobernd flobernd approved these changes

@l-trotta l-trotta Awaiting requested review from l-trotta

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pquentin @JoshMock @flobernd