Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 22, 2024

This PR adds more @ext_doc_id values and more x-model overlays for deeply nested Elasticsearch schema objects.

It also adds a comment in the introduction about the "work-in-progress" state of content on the "main" branch, to match what's in our other docs.

@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
msearch 🟢 17/17 16/16
search 🔴 2213/2273 2254/2255

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl requested a review from a user October 22, 2024 23:00
@lcawl lcawl marked this pull request as ready for review October 22, 2024 23:00
@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
msearch 🟢 17/17 16/16
search 🔴 2213/2273 2254/2255

You can validate these APIs yourself by using the make validate target.

@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
msearch 🟢 17/17 16/16
search 🔴 2213/2273 2254/2255

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit dad2aa1 into main Oct 23, 2024
6 checks passed
@lcawl lcawl deleted the lcawl/x-model branch October 23, 2024 22:02
github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants