Skip to content

Conversation

@pquentin
Copy link
Member

@pquentin pquentin commented Oct 30, 2024

The recent changes round ext_doc_url seem to have broken compilation. Having that checked in CI will avoid the problem in the future.

@pquentin pquentin requested a review from a team as a code owner October 30, 2024 05:34
@pquentin pquentin requested a review from lcawl October 30, 2024 05:48
@Anaethelion
Copy link
Contributor

@lcawl We've synced the output between the two versions of the compiler, could you have a look and check if we've broken anything on your side? Thank you!

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output from "make generate" and "make transform-to-openapi" seems to be unaffected by this PR, so it seems fine as far as docs impact!

@pquentin pquentin merged commit aafe443 into main Nov 8, 2024
7 checks passed
@pquentin pquentin deleted the fix-compiler-rs branch November 8, 2024 16:40
swallez pushed a commit that referenced this pull request Jan 15, 2025
swallez pushed a commit that referenced this pull request Jan 15, 2025
swallez added a commit that referenced this pull request Jan 15, 2025
Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants