Skip to content

Conversation

@pquentin
Copy link
Member

@pquentin pquentin commented Nov 5, 2024

As added in elastic/elasticsearch#114548. An alternative to fix the failure is to ignore the new "Test ip_location processor with defaults" test.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.delete_geoip_database 🟢 1/1 1/1
ingest.delete_pipeline 🟢 15/15 15/15
ingest.geo_ip_stats 🟢 1/1 1/1
ingest.get_geoip_database 🟢 6/6 6/6
ingest.get_pipeline 🟢 22/22 22/22
ingest.processor_grok 🟢 1/1 1/1
ingest.put_geoip_database 🟢 3/3 3/3
ingest.put_pipeline 🟢 60/60 60/60
ingest.simulate 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.delete_geoip_database 🟢 1/1 1/1
ingest.delete_pipeline 🟢 15/15 15/15
ingest.geo_ip_stats 🟢 1/1 1/1
ingest.get_geoip_database 🟢 6/6 6/6
ingest.get_pipeline 🟢 22/22 22/22
ingest.processor_grok 🟢 1/1 1/1
ingest.put_geoip_database 🟢 3/3 3/3
ingest.put_pipeline 🟢 60/60 60/60
ingest.simulate 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin requested a review from joegallo November 8, 2024 09:51
@pquentin pquentin changed the title Add undocumented ip_location ingest processor Add ip_location ingest processor Nov 8, 2024
Copy link
Contributor

@joegallo joegallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@pquentin pquentin merged commit 36dbbd9 into main Nov 9, 2024
8 checks passed
@pquentin pquentin deleted the ip-location-ingest-processor branch November 9, 2024 04:56
github-actions bot pushed a commit that referenced this pull request Nov 9, 2024
github-actions bot pushed a commit that referenced this pull request Nov 9, 2024
pquentin added a commit that referenced this pull request Nov 10, 2024
(cherry picked from commit 36dbbd9)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Nov 10, 2024
(cherry picked from commit 36dbbd9)

Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants