Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions output/openapi/elasticsearch-openapi.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions output/openapi/elasticsearch-serverless-openapi.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 14 additions & 1 deletion output/schema/schema-serverless.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 14 additions & 1 deletion output/schema/schema.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions output/typescript/types.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,12 @@ export interface Request extends RequestBase {
* @server_default open
*/
expand_wildcards?: ExpandWildcards
/**
* If `false`, creating a point in time request when a shard is missing or unavailable will throw an exception.
* If `true`, the point in time will contain all the shards that are available at the time of the request.
* @server_default false
*/
allow_partial_search_results?: boolean
}
body: {
/**
Expand Down
4 changes: 4 additions & 0 deletions specification/_json_spec/open_point_in_time.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@
"type": "string",
"description": "Specific the time to live for the point in time",
"required": true
},
"allow_partial_search_results": {
"type": "boolean",
"description": "Specifiy whether to tolerate shards missing from the point in time creation, or throw an exception if any shard is missing. (default: false)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the JSON spec change is a nice touch, thank you! The source of truth is still Elasticsearch, and we have automation that copies over the files from Elasticsearch. Was this file fixed in the Elasticsearch repo too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was about to setup a new PR for that; but good to know that automation will take care of this! Should I remove this part to avoid potential conflicts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, just to be on the safe side, would automation also handle backports if needed?

Copy link
Member

@pquentin pquentin Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the automation handles backports, and your change won't cause a conflict. I do think it's good to have here.

Even if the content ends up being different in Elasticsearch itself, we'll have a PR to review with the updated content.

}
},
"body": {
Expand Down