Skip to content

Conversation

@pquentin
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
watcher.ack_watch 🟢 1/1 1/1
watcher.activate_watch 🟢 1/1 1/1
watcher.deactivate_watch 🟢 1/1 1/1
watcher.delete_watch 🟢 2/2 2/2
watcher.execute_watch 🟢 7/7 7/7
watcher.get_settings 🟠 Missing type Missing type
watcher.get_watch 🟢 9/9 9/9
watcher.put_watch 🔴 37/38 38/38
watcher.query_watches Missing test Missing test
watcher.start 🟢 1/1 1/1
watcher.stats 🟢 1/1 1/1
watcher.stop 🟢 1/1 1/1
watcher.update_settings 🟠 Missing type Missing type

You can validate these APIs yourself by using the make validate target.

@pquentin
Copy link
Member Author

Thank you for the review! I removed the watcher changes to make this pull request self-contained and easy to revert if needed.

@pquentin pquentin merged commit 8100599 into main Nov 27, 2024
7 checks passed
@pquentin pquentin deleted the git-make-validate branch November 27, 2024 05:13
github-actions bot pushed a commit that referenced this pull request Nov 27, 2024
github-actions bot pushed a commit that referenced this pull request Nov 27, 2024
github-actions bot pushed a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants