Skip to content

Conversation

@pquentin
Copy link
Member

I'm using a simplified version of the Kibana OpenAPI for one endpoint. Simplifications include:

That said, I'm able to generate a schema.json file (that can be used to generate client) from this simplified OpenAPI representation. This is tested using https://insta.rs/.

@pquentin pquentin requested a review from a team as a code owner November 29, 2024 13:20
Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, could you add some comments on the endpoints.rs file? There's a lot of pattern matching and its not always obvious what each does.

@pquentin pquentin added the skip-backport This pull request should not be backported label Mar 11, 2025
@pquentin
Copy link
Member Author

Sorry for the late reply. Assuming you are referring to generate_get_request, I'm not sure what I can add here, since well, I'm following the OpenAPI structure, and already return Err with descriptions in cases that I don't handle.w

Anyway, closing this for now as it's now stale with the work on examples.

@pquentin pquentin closed this Jun 17, 2025
@pquentin pquentin deleted the kibana-endpoint branch October 29, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler skip-backport This pull request should not be backported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants