Skip to content

Conversation

@l-trotta
Copy link
Contributor

@l-trotta l-trotta commented Dec 5, 2024

Removes validation errors in #3251

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.exists_alias 🟢 37/37 37/37
indices.get_alias 🟢 68/68 68/68

You can validate these APIs yourself by using the make validate target.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Note that you could also have directly pushed those changes to #3251. Maybe this way helps with backports?

@l-trotta
Copy link
Contributor Author

l-trotta commented Dec 5, 2024

the problem with pushing directly is that at some point during the night it reloads the changes and I lose the commits

@l-trotta
Copy link
Contributor Author

l-trotta commented Dec 5, 2024

also this is just for 9, no backports

@l-trotta l-trotta merged commit 5485843 into main Dec 5, 2024
7 checks passed
@l-trotta l-trotta deleted the fixing-validation branch December 5, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants