Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 17, 2024

Relates to #3226

This PR edits the text structure APIs https://www.elastic.co/docs/api/doc/elasticsearch/group/endpoint-text_structure based on https://www.elastic.co/guide/en/elasticsearch/reference/master/text-structure-apis.html.

NOTE: There are two APIs in the old docs that don't exist in the specifications, so they will also need to be edited once that work is complete.

@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
text_structure.find_structure 🟢 2/2 2/2
text_structure.test_grok_pattern 🟢 2/2 2/2

You can validate these APIs yourself by using the make validate target.

Copy link

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🫏

@lcawl lcawl merged commit 14ddb71 into main Dec 18, 2024
11 checks passed
@lcawl lcawl deleted the text-structure-summaries branch December 18, 2024 00:17
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
lcawl added a commit that referenced this pull request Dec 18, 2024
(cherry picked from commit 14ddb71)

Co-authored-by: Lisa Cawley <[email protected]>
lcawl added a commit that referenced this pull request Dec 19, 2024
(cherry picked from commit 14ddb71)

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants