Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 1, 2025

Relates to #3377

This PR adds a missing specification based on https://www.elastic.co/guide/en/elasticsearch/reference/master/repo-analysis-api.html

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
snapshot.repository_analyze Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review January 2, 2025 16:32
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
snapshot.repository_analyze Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
snapshot.repository_analyze Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin self-assigned this Jan 7, 2025
/**
* The limit on the size of a blob written during the test.
*/
max_blob_size: string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this field and the following ones be modeled as ByteSize?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated these properties to use "Duration" and "ByteSize" data types in b151058

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
snapshot.repository_analyze Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@lcawl
Copy link
Contributor Author

lcawl commented Jan 9, 2025

I think I've addressed all the feedback, thanks!

@pquentin pquentin removed their assignment Jan 13, 2025
Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you 🙂

@lcawl lcawl merged commit fa1f90c into main Jan 15, 2025
8 checks passed
@lcawl lcawl deleted the respository-analysis branch January 15, 2025 15:33
github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
Co-authored-by: Florian Bernd <[email protected]>
(cherry picked from commit fa1f90c)
github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
Co-authored-by: Florian Bernd <[email protected]>
(cherry picked from commit fa1f90c)
lcawl added a commit that referenced this pull request Jan 15, 2025
Co-authored-by: Florian Bernd <[email protected]>
(cherry picked from commit fa1f90c)

Co-authored-by: Lisa Cawley <[email protected]>
lcawl added a commit that referenced this pull request Jan 15, 2025
Co-authored-by: Florian Bernd <[email protected]>
(cherry picked from commit fa1f90c)

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants