Skip to content

Improve RoleMappingRule definition #3749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Improve RoleMappingRule definition #3749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 31 additions & 52 deletions output/schema/schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 1 addition & 7 deletions output/typescript/types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 3 additions & 15 deletions specification/security/_types/RoleMappingRule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,27 +17,15 @@
* under the License.
*/

import { Names } from '@_types/common'
import { SingleKeyDictionary } from '@spec_utils/Dictionary'
import { Field, FieldValue } from '@_types/common'

/**
* @variants container
*/
export class RoleMappingRule {
any?: RoleMappingRule[]
all?: RoleMappingRule[]
// `field` should have been defined as SingleKeyDictionary<String, ScalarValue|ScalarValue[]>
// However, this was initially defined as a container with a limited number of variants,
// and was later made non_exhaustive to limit breaking changes.
field?: FieldRule
field?: SingleKeyDictionary<Field, FieldValue | FieldValue[]>
except?: RoleMappingRule
}

/**
* @variants container
* @non_exhaustive
*/
export class FieldRule {
username?: Names
dn?: Names
groups?: Names
}