[ML] Update start model deployment & update model deployment APIs

[rbrtj]

The ml.start_trained_model_deployment and ml.update_trained_model_deployment methods are outdated. Therefore, we currently use transport.request with manual type definitions: https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/lib/ml_client/ml_client.ts#L526
The API has been updated to correctly accept adaptive_allocations settings inside the request body.

[github-actions]

Following you can find the validation results for the APIs you have changed.

API	Status	Request	Response
ml.clear_trained_model_deployment_cache	🟢	1/1	1/1
ml.close_job	🟢	64/64	63/63
ml.delete_calendar_event	🟢	4/4	4/4
ml.delete_calendar_job	🟢	3/3	3/3
ml.delete_calendar	🟢	5/5	5/5
ml.delete_data_frame_analytics	🟢	2/2	2/2
ml.delete_datafeed	🟢	3/3	3/3
ml.delete_expired_data	🟢	5/5	5/5
ml.delete_filter	🟢	27/27	27/27
ml.delete_forecast	🟢	3/3	3/3
ml.delete_job	🟢	47/47	47/47
ml.delete_model_snapshot	🟢	2/2	2/2
ml.delete_trained_model_alias	🟢	3/3	3/3
ml.delete_trained_model	🟢	5/5	5/5
ml.estimate_model_memory	🟢	16/16	16/16
ml.evaluate_data_frame	🟢	15/15	15/15
ml.explain_data_frame_analytics	🟢	7/7	7/7
ml.flush_job	🟢	15/15	15/15
ml.forecast	🟢	1/1	1/1
ml.get_buckets	🟢	14/14	14/14
ml.get_calendar_events	🟢	15/15	15/15
ml.get_calendars	🟢	17/17	17/17
ml.get_categories	🟢	12/12	12/12
ml.get_data_frame_analytics_stats	🟢	12/12	12/12
ml.get_data_frame_analytics	🟢	17/17	17/17
ml.get_datafeed_stats	🟢	27/27	27/27
ml.get_datafeeds	🟢	20/20	20/20
ml.get_filters	🟢	13/13	13/13
ml.get_influencers	🟢	11/11	11/11
ml.get_job_stats	🟢	32/32	32/32
ml.get_jobs	🟢	31/31	31/31
ml.get_memory_stats	🟢	6/6	6/6
ml.get_model_snapshot_upgrade_stats	🟢	3/3	3/3
ml.get_model_snapshots	🟢	18/18	18/18
ml.get_overall_buckets	🟢	16/16	15/15
ml.get_records	🟢	8/8	8/8
ml.get_trained_models_stats	🔴	17/17	12/17
ml.get_trained_models	🟢	37/37	37/37
ml.infer_trained_model	🟢	10/10	10/10
ml.info	🟢	10/10	10/10
ml.open_job	🟢	83/83	83/83
ml.post_calendar_events	🟢	12/12	12/12
ml.post_data	🔴	9/11	18/18
ml.preview_data_frame_analytics	🟢	3/3	3/3
ml.preview_datafeed	🟢	17/17	17/17
ml.put_calendar_job	🟢	12/12	12/12
ml.put_calendar	🟢	135/135	135/135
ml.put_data_frame_analytics	🟢	33/33	33/33
ml.put_datafeed	🟢	71/71	71/71
ml.put_filter	🟢	27/27	27/27
ml.put_job	🟢	227/227	225/225
ml.put_trained_model_alias	🟢	13/13	13/13
ml.put_trained_model_definition_part	🟢	1/1	1/1
ml.put_trained_model_vocabulary	🟢	1/1	1/1
ml.put_trained_model	🔴	8/16	16/16
ml.reset_job	🟢	2/2	2/2
ml.revert_model_snapshot	🟢	2/2	2/2
ml.set_upgrade_mode	🟢	6/6	6/6
ml.start_data_frame_analytics	🟢	1/1	1/1
ml.start_datafeed	🟢	24/24	24/24
ml.start_trained_model_deployment	🟢	14/14	14/14
ml.stop_data_frame_analytics	🟢	5/5	5/5
ml.stop_datafeed	🟢	17/17	17/17
ml.stop_trained_model_deployment	🟢	10/10	10/10
ml.update_data_frame_analytics	🟢	2/2	2/2
ml.update_datafeed	🟢	7/7	7/7
ml.update_filter	🟢	3/3	3/3
ml.update_job	🟢	5/5	5/5
ml.update_model_snapshot	🟢	3/3	3/3
ml.update_trained_model_deployment	🟢	4/4	4/4
ml.upgrade_job_snapshot	🟢	3/3	3/3
ml.validate_detector	🟢	2/2	2/2
ml.validate	🟢	3/3	3/3

You can validate these APIs yourself by using the make validate target.

[github-actions]

Following you can find the validation results for the APIs you have changed.

API	Status	Request	Response
ml.clear_trained_model_deployment_cache	🟢	1/1	1/1
ml.close_job	🟢	64/64	63/63
ml.delete_calendar_event	🟢	4/4	4/4
ml.delete_calendar_job	🟢	3/3	3/3
ml.delete_calendar	🟢	5/5	5/5
ml.delete_data_frame_analytics	🟢	2/2	2/2
ml.delete_datafeed	🟢	3/3	3/3
ml.delete_expired_data	🟢	5/5	5/5
ml.delete_filter	🟢	27/27	27/27
ml.delete_forecast	🟢	3/3	3/3
ml.delete_job	🟢	47/47	47/47
ml.delete_model_snapshot	🟢	2/2	2/2
ml.delete_trained_model_alias	🟢	3/3	3/3
ml.delete_trained_model	🟢	5/5	5/5
ml.estimate_model_memory	🟢	16/16	16/16
ml.evaluate_data_frame	🟢	15/15	15/15
ml.explain_data_frame_analytics	🟢	7/7	7/7
ml.flush_job	🟢	15/15	15/15
ml.forecast	🟢	1/1	1/1
ml.get_buckets	🟢	14/14	14/14
ml.get_calendar_events	🟢	15/15	15/15
ml.get_calendars	🟢	17/17	17/17
ml.get_categories	🟢	12/12	12/12
ml.get_data_frame_analytics_stats	🟢	12/12	12/12
ml.get_data_frame_analytics	🟢	17/17	17/17
ml.get_datafeed_stats	🟢	27/27	27/27
ml.get_datafeeds	🟢	20/20	20/20
ml.get_filters	🟢	13/13	13/13
ml.get_influencers	🟢	11/11	11/11
ml.get_job_stats	🟢	32/32	32/32
ml.get_jobs	🟢	31/31	31/31
ml.get_memory_stats	🟢	6/6	6/6
ml.get_model_snapshot_upgrade_stats	🟢	3/3	3/3
ml.get_model_snapshots	🟢	18/18	18/18
ml.get_overall_buckets	🟢	16/16	15/15
ml.get_records	🟢	8/8	8/8
ml.get_trained_models_stats	🔴	17/17	12/17
ml.get_trained_models	🟢	37/37	37/37
ml.infer_trained_model	🟢	10/10	10/10
ml.info	🟢	10/10	10/10
ml.open_job	🟢	83/83	83/83
ml.post_calendar_events	🟢	12/12	12/12
ml.post_data	🔴	9/11	18/18
ml.preview_data_frame_analytics	🟢	3/3	3/3
ml.preview_datafeed	🟢	17/17	17/17
ml.put_calendar_job	🟢	12/12	12/12
ml.put_calendar	🟢	135/135	135/135
ml.put_data_frame_analytics	🟢	33/33	33/33
ml.put_datafeed	🟢	71/71	71/71
ml.put_filter	🟢	27/27	27/27
ml.put_job	🟢	227/227	225/225
ml.put_trained_model_alias	🟢	13/13	13/13
ml.put_trained_model_definition_part	🟢	1/1	1/1
ml.put_trained_model_vocabulary	🟢	1/1	1/1
ml.put_trained_model	🔴	8/16	16/16
ml.reset_job	🟢	2/2	2/2
ml.revert_model_snapshot	🟢	2/2	2/2
ml.set_upgrade_mode	🟢	6/6	6/6
ml.start_data_frame_analytics	🟢	1/1	1/1
ml.start_datafeed	🟢	24/24	24/24
ml.start_trained_model_deployment	🟢	14/14	14/14
ml.stop_data_frame_analytics	🟢	5/5	5/5
ml.stop_datafeed	🟢	17/17	17/17
ml.stop_trained_model_deployment	🟢	10/10	10/10
ml.update_data_frame_analytics	🟢	2/2	2/2
ml.update_datafeed	🟢	7/7	7/7
ml.update_filter	🟢	3/3	3/3
ml.update_job	🟢	5/5	5/5
ml.update_model_snapshot	🟢	3/3	3/3
ml.update_trained_model_deployment	🟢	4/4	4/4
ml.upgrade_job_snapshot	🟢	3/3	3/3
ml.validate_detector	🟢	2/2	2/2
ml.validate	🟢	3/3	3/3

You can validate these APIs yourself by using the make validate target.

[davidkyle]

LGTM

thanks

[darnautov]

LGTM

[darnautov]

@davidkyle could you please check the backport labels? does the 8.x suffice?

[rbrtj]

Hey @l-trotta, I saw that you added 9.0 and 8.18 labels, and I wanted to ensure they're correct. Is it actually possible to get it into already feature-frozen branches?

[l-trotta]

@rbrtj yes most of the client don't follow the DRA process, so backporting to 8.18 and 9.0 is the only way for all clients to have these fixes in those versions