Add reason to migration.post_feature_upgrade API #4233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
pquentin
changed the title
pquentin
changed the title
l-trotta
approved these changes
May 7, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2025
(cherry picked from commit 7a7e2a2)
l-trotta
added a commit
that referenced
this pull request
May 7, 2025
(cherry picked from commit 7a7e2a2) Co-authored-by: Quentin Pradet <[email protected]> Co-authored-by: Laura Trotta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server code: https://github.com/elastic/elasticsearch/blob/a6ffeeeb710d72352a2d400c404c4543059f23d1/x-pack/plugin/migrate/src/main/java/org/elasticsearch/system_indices/action/PostFeatureUpgradeResponse.java#L65-L87
There's also the optional
ElasticsearchExceptionbut that seems to tricky to model given the recursivity and overall complexity.