-
Notifications
You must be signed in to change notification settings - Fork 115
Adding specification for the new data stream settings APIs #4416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
specification/_doc_ids/table.csv
Outdated
| indices-get-template,https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-indices-get-index-template | ||
| indices-get-template-v1,https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-indices-get-template | ||
| indices-open-close,https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-indices-open | ||
| indices-put-data-stream-settings,https://www.elastic.co/guide/en/elasticsearch/reference/master/data-streams.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only URL in this whole file that links to a docs v2 page. @lcawl @georgewallace Does this need to be changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had just put in the placeholder we had used on the elasticsearch side. I can change it to something else. Looking now to see what fits best.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a lot of minor suggestions, but the important one is related to the @doc_tag. It would also be nice to have request and response examples per https://github.com/elastic/elasticsearch-specification/blob/main/docs/add-new-api.md#add-endpoint-request-and-response-examples
specification/indices/get_data_stream_settings/IndicesGetDataStreamSettingsRequest.ts
Show resolved
Hide resolved
specification/indices/get_data_stream_settings/IndicesGetDataStreamSettingsRequest.ts
Show resolved
Hide resolved
specification/indices/put_data_stream_settings/IndicesPutDataStreamSettingsRequest.ts
Show resolved
Hide resolved
specification/indices/put_data_stream_settings/IndicesPutDataStreamSettingsRequest.ts
Outdated
Show resolved
Hide resolved
specification/indices/put_data_stream_settings/IndicesPutDataStreamSettingsRequest.ts
Outdated
Show resolved
Hide resolved
specification/indices/put_data_stream_settings/IndicesPutDataStreamSettingsRequest.ts
Outdated
Show resolved
Hide resolved
specification/indices/put_data_stream_settings/IndicesPutDataStreamSettingsRequest.ts
Outdated
Show resolved
Hide resolved
specification/indices/put_data_stream_settings/IndicesPutDataStreamSettingsResponse.ts
Show resolved
Hide resolved
specification/indices/put_data_stream_settings/IndicesPutDataStreamSettingsResponse.ts
Outdated
Show resolved
Hide resolved
specification/indices/put_data_stream_settings/IndicesPutDataStreamSettingsResponse.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Lisa Cawley <[email protected]>
specification/indices/get_data_stream_settings/IndicesGetDataStreamSettingsResponse.ts
Show resolved
Hide resolved
specification/indices/put_data_stream_settings/IndicesPutDataStreamSettingsRequest.ts
Show resolved
Hide resolved
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few more minor suggestions related to changes in the way we're generating examples and annotating availability, but otherwise LGTM
specification/indices/get_data_stream_settings/IndicesGetDataStreamSettingsRequest.ts
Show resolved
Hide resolved
specification/indices/put_data_stream_settings/IndicesPutDataStreamSettingsRequest.ts
Show resolved
Hide resolved
...data_stream_settings/examples/200_response/IndicesGetDataStreamSettingsResponseExample1.yaml
Show resolved
Hide resolved
...data_stream_settings/examples/200_response/IndicesPutDataStreamSettingsResponseExample1.yaml
Show resolved
Hide resolved
...data_stream_settings/examples/200_response/IndicesPutDataStreamSettingsResponseExample2.yaml
Show resolved
Hide resolved
...data_stream_settings/examples/200_response/IndicesPutDataStreamSettingsResponseExample3.yaml
Show resolved
Hide resolved
...s/put_data_stream_settings/examples/request/IndicesPutDataStreamSettingsRequestExample1.yaml
Show resolved
Hide resolved
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-4416-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9e631d8579446c2c24e91995d4a93654773047c4
# Push it to GitHub
git push --set-upstream origin backport-4416-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19Then, create a pull request where the |
(cherry picked from commit 9e631d8)
…5342) (cherry picked from commit 9e631d8) Co-authored-by: Quentin Pradet <[email protected]>
This adds specifications for the new data stream settings APIs.