Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Jun 3, 2025

Relates to #4345
In particular, relates to the following caveat from #4313

Caveat: for unary values (i.e. not an array or lenient array), bump.sh will still render its list below the descriptions added by this PR. This could be avoided by removing the enumeration values from the OpenAPI spec...

This PR tests that suggestion for the following cat API: https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-cat-ml-jobs

Preview

Before

Redundant list exists (though collapsed by default):

image

After

Redundant list is removed:

image

@lcawl lcawl requested review from georgewallace and szabosteve June 3, 2025 00:10
@lcawl lcawl marked this pull request as ready for review June 3, 2025 00:10
@lcawl lcawl added the OpenAPI label Jun 3, 2025
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcawl lcawl merged commit ba32be2 into main Jun 4, 2025
18 checks passed
@lcawl lcawl deleted the cat-enums branch June 4, 2025 23:42
github-actions bot pushed a commit that referenced this pull request Jun 4, 2025
github-actions bot pushed a commit that referenced this pull request Jun 4, 2025
github-actions bot pushed a commit that referenced this pull request Jun 4, 2025
lcawl added a commit that referenced this pull request Jun 4, 2025
lcawl added a commit that referenced this pull request Jun 4, 2025
lcawl added a commit that referenced this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants