Correct map types #4469
Merged
Correct map types #4469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
Contributor
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
pquentin
approved these changes
Jun 6, 2025
Member
pquentin
left a comment
pquentin
left a comment
There was a problem hiding this comment.
Thanks! LGTM. We agreed offline that this breaking change was worth it for 9.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tokensis actually a list of WeightedToken objects, but since the field is a sting let's make it a list of Single Key Dictionaries (source: server code)