-
Notifications
You must be signed in to change notification settings - Fork 115
Fixing indices create partially #4652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
b1d3671
9b39b8a
4ff3da0
5976389
01abd3f
f90bf1b
a816e1b
779cdd2
1bf6ea5
ca7c65d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -213,7 +213,14 @@ export class RankFeaturesProperty extends PropertyBase { | |
| type: 'rank_features' | ||
| } | ||
|
|
||
| export class RankVectorProperty extends PropertyBase { | ||
| type: 'rank_vectors' | ||
| element_type?: RankVectorElementType | ||
| dims?: integer | ||
| } | ||
|
|
||
|
Comment on lines
+220
to
+225
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a technical preview feature, how can we specify it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could this work? since type is the internal tag There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually, I don't think that is possible today, see #2830. Leaving this for future work then. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we add a comment at least? |
||
| export class SparseVectorProperty extends PropertyBase { | ||
| store?: boolean | ||
| type: 'sparse_vector' | ||
| } | ||
|
|
||
|
|
@@ -364,3 +371,9 @@ export class DynamicProperty extends DocValuesPropertyBase { | |
| precision_step?: integer | ||
| locale?: string | ||
| } | ||
|
|
||
| export enum RankVectorElementType { | ||
| byte, | ||
| float, | ||
| bit | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -534,44 +534,15 @@ export class SlowlogTresholdLevels { | |
| } | ||
|
|
||
| export class Storage { | ||
| type: StorageType | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| /** | ||
| * You can restrict the use of the mmapfs and the related hybridfs store type via the setting node.store.allow_mmap. | ||
| * This is a boolean setting indicating whether or not memory-mapping is allowed. The default is to allow it. This | ||
| * setting is useful, for example, if you are in an environment where you can not control the ability to create a lot | ||
| * of memory maps so you need disable the ability to use memory-mapping. | ||
| */ | ||
| allow_mmap?: boolean | ||
| } | ||
|
|
||
| /** | ||
| * @non_exhaustive | ||
| */ | ||
| export enum StorageType { | ||
| /** | ||
| * Default file system implementation. This will pick the best implementation depending on the operating environment, which | ||
| * is currently hybridfs on all supported systems but is subject to change. | ||
| */ | ||
| fs, | ||
| /** | ||
| * The NIO FS type stores the shard index on the file system (maps to Lucene NIOFSDirectory) using NIO. It allows multiple | ||
| * threads to read from the same file concurrently. It is not recommended on Windows because of a bug in the SUN Java | ||
| * implementation and disables some optimizations for heap memory usage. | ||
| */ | ||
| niofs, | ||
| /** | ||
| * The MMap FS type stores the shard index on the file system (maps to Lucene MMapDirectory) by mapping a file into | ||
| * memory (mmap). Memory mapping uses up a portion of the virtual memory address space in your process equal to the size | ||
| * of the file being mapped. Before using this class, be sure you have allowed plenty of virtual address space. | ||
| */ | ||
| mmapfs, | ||
| /** | ||
| * The hybridfs type is a hybrid of niofs and mmapfs, which chooses the best file system type for each type of file | ||
| * based on the read access pattern. Currently only the Lucene term dictionary, norms and doc values files are memory | ||
| * mapped. All other files are opened using Lucene NIOFSDirectory. Similarly to mmapfs be sure you have allowed | ||
| * plenty of virtual address space. | ||
| */ | ||
| hybridfs | ||
| /** How often store statistics are refreshed */ | ||
| stats_refresh_interval?: Duration | ||
| } | ||
|
|
||
| export class IndexingPressure { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which generator? I think we should discuss this before making it wrongly optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah sorry wrong wording, I mean the ts compiler. if you look at
elasticsearch-specification/output/typescript/types.ts
Line 4804 in cdaa4ef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right
aliasesseem to be a recipe for problem, as their generation is pretty naive. I added a comment to #4599 (comment) to mention it. In the meantime, making this optional just because we can't handle it still seems wrong.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, reverting then