Add specs for Semantic Text index options #4690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
Thanks! LGTM.
So we did not use any inference YAML tests until now but elastic/elasticsearch#130070 will fix it. In the meantime, I can confirm that this PR fixes all the errors we would have seen when trying to validate against the YAML tests added in elastic/elasticsearch#119967.
Regarding the lint error, can you please try running make setup again? We changed our dependencies recently and the import order changed.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 26, 2025
* Add specs for Semantic Text index options * Linting * Run make contrib --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit cdaa4ef)
pquentin
added a commit
that referenced
this pull request
Jun 26, 2025
* Add specs for Semantic Text index options * Linting * Run make contrib --------- (cherry picked from commit cdaa4ef) Co-authored-by: Kathleen DeRusso <[email protected]> Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
index_optionsforsemantic_textfields to the specification, which were introduced through elastic/elasticsearch#119967Note: This design only supports
dense_vectorbut we anticipate thatsparse_vectorwill be a fast follow.