Adds cat node -h enumerated values #4736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Following you can find the validation changes for the API you have modified.
You can validate this API yourself by using the |
pquentin
reviewed
Jul 1, 2025
Member
pquentin
left a comment
pquentin
left a comment
There was a problem hiding this comment.
The validation is failing because you were using the string version in two cases, not the string | string[] version.
Co-authored-by: Quentin Pradet <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]>
pquentin
approved these changes
Jul 1, 2025
Member
pquentin
left a comment
pquentin
left a comment
There was a problem hiding this comment.
Thanks! LGTM. Validation now passes, but due to a weird behavior in the validation CI, it looks like it does not.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
* Adds cat node -h enumerated values * Update specification/cat/recovery/CatRecoveryRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * Update specification/cat/recovery/CatRecoveryRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * Update specification/cat/segments/CatSegmentsRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * Update specification/cat/segments/CatSegmentsRequest.ts Co-authored-by: Quentin Pradet <[email protected]> --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 7b834b0)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
* Adds cat node -h enumerated values * Update specification/cat/recovery/CatRecoveryRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * Update specification/cat/recovery/CatRecoveryRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * Update specification/cat/segments/CatSegmentsRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * Update specification/cat/segments/CatSegmentsRequest.ts Co-authored-by: Quentin Pradet <[email protected]> --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 7b834b0)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
* Adds cat node -h enumerated values * Update specification/cat/recovery/CatRecoveryRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * Update specification/cat/recovery/CatRecoveryRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * Update specification/cat/segments/CatSegmentsRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * Update specification/cat/segments/CatSegmentsRequest.ts Co-authored-by: Quentin Pradet <[email protected]> --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 7b834b0)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
* Adds cat node -h enumerated values * Update specification/cat/recovery/CatRecoveryRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * Update specification/cat/recovery/CatRecoveryRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * Update specification/cat/segments/CatSegmentsRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * Update specification/cat/segments/CatSegmentsRequest.ts Co-authored-by: Quentin Pradet <[email protected]> --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 7b834b0)
pquentin
added a commit
that referenced
this pull request
Jul 1, 2025
* Adds cat node -h enumerated values * Update specification/cat/recovery/CatRecoveryRequest.ts * Update specification/cat/recovery/CatRecoveryRequest.ts * Update specification/cat/segments/CatSegmentsRequest.ts * Update specification/cat/segments/CatSegmentsRequest.ts --------- (cherry picked from commit 7b834b0) Co-authored-by: kosabogi <[email protected]> Co-authored-by: Quentin Pradet <[email protected]>
pquentin
added a commit
that referenced
this pull request
Jul 1, 2025
* Adds cat node -h enumerated values * Update specification/cat/recovery/CatRecoveryRequest.ts * Update specification/cat/recovery/CatRecoveryRequest.ts * Update specification/cat/segments/CatSegmentsRequest.ts * Update specification/cat/segments/CatSegmentsRequest.ts --------- (cherry picked from commit 7b834b0) Co-authored-by: kosabogi <[email protected]> Co-authored-by: Quentin Pradet <[email protected]>
pquentin
added a commit
that referenced
this pull request
Jul 1, 2025
* Adds cat node -h enumerated values * Update specification/cat/recovery/CatRecoveryRequest.ts * Update specification/cat/recovery/CatRecoveryRequest.ts * Update specification/cat/segments/CatSegmentsRequest.ts * Update specification/cat/segments/CatSegmentsRequest.ts --------- (cherry picked from commit 7b834b0) Co-authored-by: kosabogi <[email protected]> Co-authored-by: Quentin Pradet <[email protected]>
pquentin
added a commit
that referenced
this pull request
Jul 1, 2025
* Adds cat node -h enumerated values * Update specification/cat/recovery/CatRecoveryRequest.ts * Update specification/cat/recovery/CatRecoveryRequest.ts * Update specification/cat/segments/CatSegmentsRequest.ts * Update specification/cat/segments/CatSegmentsRequest.ts --------- (cherry picked from commit 7b834b0) Co-authored-by: kosabogi <[email protected]> Co-authored-by: Quentin Pradet <[email protected]>
Contributor
Author
Thank you for your review and for merging this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the enumerated values for the -h parameter in the following APIs:
Related issue: #4345