Adds cat node -h values #4771
Merged
Adds cat node -h values #4771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Following you can find the validation changes for the API you have modified.
You can validate this API yourself by using the |
lcawl
reviewed
Jul 3, 2025
Contributor
|
I tested the output by running the following commands: And the output looks good when I upload it to our publishing site. For example:
|
lcawl
approved these changes
Jul 3, 2025
Contributor
lcawl
left a comment
lcawl
left a comment
There was a problem hiding this comment.
Left two minor comments, otherwise output LGTM!
pquentin
approved these changes
Jul 4, 2025
Member
pquentin
left a comment
pquentin
left a comment
There was a problem hiding this comment.
Validation is failing because of a missing s, the rest looks good, thanks!
(I have not checked the actual list of values though.)
Co-authored-by: Lisa Cawley <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 4, 2025
* add cat shards -h values * add cat thead_pool -h values * Fix format * Fix bulleted list * Update specification/cat/_types/CatBase.ts Co-authored-by: Lisa Cawley <[email protected]> * Update specification/cat/thread_pool/CatThreadPoolRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * Update specification/cat/thread_pool/CatThreadPoolRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * fix typo --------- Co-authored-by: lcawl <[email protected]> Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 3df6bb7)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 4, 2025
* add cat shards -h values * add cat thead_pool -h values * Fix format * Fix bulleted list * Update specification/cat/_types/CatBase.ts Co-authored-by: Lisa Cawley <[email protected]> * Update specification/cat/thread_pool/CatThreadPoolRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * Update specification/cat/thread_pool/CatThreadPoolRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * fix typo --------- Co-authored-by: lcawl <[email protected]> Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 3df6bb7)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 4, 2025
* add cat shards -h values * add cat thead_pool -h values * Fix format * Fix bulleted list * Update specification/cat/_types/CatBase.ts Co-authored-by: Lisa Cawley <[email protected]> * Update specification/cat/thread_pool/CatThreadPoolRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * Update specification/cat/thread_pool/CatThreadPoolRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * fix typo --------- Co-authored-by: lcawl <[email protected]> Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 3df6bb7)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 4, 2025
* add cat shards -h values * add cat thead_pool -h values * Fix format * Fix bulleted list * Update specification/cat/_types/CatBase.ts Co-authored-by: Lisa Cawley <[email protected]> * Update specification/cat/thread_pool/CatThreadPoolRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * Update specification/cat/thread_pool/CatThreadPoolRequest.ts Co-authored-by: Quentin Pradet <[email protected]> * fix typo --------- Co-authored-by: lcawl <[email protected]> Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 3df6bb7)
charlotte-hoblik
added a commit
that referenced
this pull request
Jul 4, 2025
* add cat shards -h values * add cat thead_pool -h values * Fix format * Fix bulleted list * Update specification/cat/_types/CatBase.ts * Update specification/cat/thread_pool/CatThreadPoolRequest.ts * Update specification/cat/thread_pool/CatThreadPoolRequest.ts * fix typo --------- (cherry picked from commit 3df6bb7) Co-authored-by: Charlotte Hoblik <[email protected]> Co-authored-by: lcawl <[email protected]> Co-authored-by: Quentin Pradet <[email protected]>
charlotte-hoblik
pushed a commit
that referenced
this pull request
Jul 4, 2025
charlotte-hoblik
pushed a commit
that referenced
this pull request
Jul 4, 2025
charlotte-hoblik
pushed a commit
that referenced
this pull request
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the enumerated values for the -h parameter in the following APIs:
Related issue: #4345