Adding the merge_type param to the ingest simulate API #5140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
changed the title
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
seanzatzdev
reviewed
Aug 13, 2025
| }, | ||
| "merge_type": { | ||
| "type": "string", | ||
| "description": "The way that mapping_additions ought to be merged into existing mappings" |
There was a problem hiding this comment.
Just a suggestion, but thought the description from your original PR was easier for me to understand
allows a user to specify exactly how they would like the mappings merged. The options are index or template. By default, they will be merged using the index strategy to maintain backwards compatibility.
seanzatzdev
approved these changes
Aug 13, 2025
l-trotta
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the new
merge_typequery parameter to the specification for the simulate ingest API. The parameter was added in elastic/elasticsearch#132210.