Skip to content

Conversation

@jxie-1
Copy link
Contributor

@jxie-1 jxie-1 commented Aug 20, 2025

In serverless, only GET is supported for the task management API, so users can't cancel a task.

I think this is the simplest fix, as monitoring the reindex task is probably the most relevant part for troubleshooting. I can also make the description more granular if that's a better approach

@github-actions
Copy link
Contributor

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

Copy link

@BrianRothermich BrianRothermich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@jxie-1 jxie-1 merged commit 5a23786 into main Aug 21, 2025
8 checks passed
@jxie-1 jxie-1 deleted the reindex-task-api branch August 21, 2025 20:08
@github-actions
Copy link
Contributor

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5170-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5a2378699bf7afe4757b2e62261518b1b6f28b66
# Push it to GitHub
git push --set-upstream origin backport-5170-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-5170-to-8.19.

@github-actions
Copy link
Contributor

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-5170-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5a2378699bf7afe4757b2e62261518b1b6f28b66
# Push it to GitHub
git push --set-upstream origin backport-5170-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-5170-to-8.18.

github-actions bot pushed a commit that referenced this pull request Aug 21, 2025
* Generalize comment on monitoring reindex tasks

* Update specification/_global/reindex/ReindexRequest.ts

Co-authored-by: Liam Thompson <[email protected]>

* Update json files

---------

Co-authored-by: Liam Thompson <[email protected]>
(cherry picked from commit 5a23786)
github-actions bot pushed a commit that referenced this pull request Aug 21, 2025
* Generalize comment on monitoring reindex tasks

* Update specification/_global/reindex/ReindexRequest.ts

Co-authored-by: Liam Thompson <[email protected]>

* Update json files

---------

Co-authored-by: Liam Thompson <[email protected]>
(cherry picked from commit 5a23786)
l-trotta pushed a commit that referenced this pull request Aug 28, 2025
* Generalize comment on monitoring reindex tasks

* Update specification/_global/reindex/ReindexRequest.ts



* Update json files

---------


(cherry picked from commit 5a23786)

Co-authored-by: Justin Xie <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
l-trotta pushed a commit that referenced this pull request Aug 28, 2025
* Generalize comment on monitoring reindex tasks

* Update specification/_global/reindex/ReindexRequest.ts



* Update json files

---------


(cherry picked from commit 5a23786)

Co-authored-by: Justin Xie <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants