-
Notifications
You must be signed in to change notification settings - Fork 115
Generalize comment on monitoring reindex tasks #5170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
BrianRothermich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM
Co-authored-by: Liam Thompson <[email protected]>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5170-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5a2378699bf7afe4757b2e62261518b1b6f28b66
# Push it to GitHub
git push --set-upstream origin backport-5170-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-5170-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5a2378699bf7afe4757b2e62261518b1b6f28b66
# Push it to GitHub
git push --set-upstream origin backport-5170-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18Then, create a pull request where the |
* Generalize comment on monitoring reindex tasks * Update specification/_global/reindex/ReindexRequest.ts Co-authored-by: Liam Thompson <[email protected]> * Update json files --------- Co-authored-by: Liam Thompson <[email protected]> (cherry picked from commit 5a23786)
* Generalize comment on monitoring reindex tasks * Update specification/_global/reindex/ReindexRequest.ts Co-authored-by: Liam Thompson <[email protected]> * Update json files --------- Co-authored-by: Liam Thompson <[email protected]> (cherry picked from commit 5a23786)
* Generalize comment on monitoring reindex tasks * Update specification/_global/reindex/ReindexRequest.ts * Update json files --------- (cherry picked from commit 5a23786) Co-authored-by: Justin Xie <[email protected]> Co-authored-by: Liam Thompson <[email protected]>
* Generalize comment on monitoring reindex tasks * Update specification/_global/reindex/ReindexRequest.ts * Update json files --------- (cherry picked from commit 5a23786) Co-authored-by: Justin Xie <[email protected]> Co-authored-by: Liam Thompson <[email protected]>
In serverless, only GET is supported for the task management API, so users can't cancel a task.
I think this is the simplest fix, as monitoring the reindex task is probably the most relevant part for troubleshooting. I can also make the description more granular if that's a better approach