Skip to content

Conversation

@pquentin
Copy link
Member

This came up when working on elastic/elasticsearch#133386.

@github-actions
Copy link
Contributor

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit 01182b0 into main Aug 29, 2025
10 of 11 checks passed
@pquentin pquentin deleted the enforce-doc-ids branch August 29, 2025 07:20
@github-actions
Copy link
Contributor

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5198-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 01182b0b19cd19a33ef51790d68c82604e51c4fa
# Push it to GitHub
git push --set-upstream origin backport-5198-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-5198-to-8.19.

@github-actions
Copy link
Contributor

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-5198-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 01182b0b19cd19a33ef51790d68c82604e51c4fa
# Push it to GitHub
git push --set-upstream origin backport-5198-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-5198-to-8.18.

@github-actions
Copy link
Contributor

The backport to 9.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-5198-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 01182b0b19cd19a33ef51790d68c82604e51c4fa
# Push it to GitHub
git push --set-upstream origin backport-5198-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0

Then, create a pull request where the base branch is 9.0 and the compare/head branch is backport-5198-to-9.0.

github-actions bot pushed a commit that referenced this pull request Aug 29, 2025
* Enforce doc_id tag on public APIs

* Fix tests

* Add doc_id test

(cherry picked from commit 01182b0)
pquentin added a commit that referenced this pull request Aug 29, 2025
* Enforce doc_id tag on public APIs

* Fix tests

* Add doc_id test

(cherry picked from commit 01182b0)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Aug 29, 2025
* Enforce doc_id tag on public APIs

* Fix tests

* Add doc_id test

(cherry picked from commit 01182b0)

# Conflicts:
#	output/schema/schema.json
#	specification/_doc_ids/table.csv
#	specification/esql/get_query/GetQueryRequest.ts
#	specification/esql/list_queries/ListQueriesRequest.ts
#	specification/indices/delete_data_stream_options/IndicesDeleteDataStreamOptionsRequest.ts
#	specification/indices/get_data_stream_options/IndicesGetDataStreamOptionsRequest.ts
#	specification/indices/put_data_stream_options/IndicesPutDataStreamOptionsRequest.ts
@pquentin
Copy link
Member Author

💔 Some backports could not be created

Status Branch Result
9.0
8.19 Conflict resolution was aborted by the user
8.18 The branch "elastic/8.18'" is invalid or doesn't exist

Manual backport

To create the backport manually run:

backport --pr 5198

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Aug 29, 2025
* Enforce doc_id tag on public APIs

* Fix tests

* Add doc_id test

(cherry picked from commit 01182b0)

# Conflicts:
#	output/schema/schema.json
#	specification/_doc_ids/table.csv
#	specification/esql/get_query/GetQueryRequest.ts
#	specification/esql/list_queries/ListQueriesRequest.ts
#	specification/indices/delete_data_stream_options/IndicesDeleteDataStreamOptionsRequest.ts
#	specification/indices/get_data_stream_options/IndicesGetDataStreamOptionsRequest.ts
#	specification/indices/put_data_stream_options/IndicesPutDataStreamOptionsRequest.ts
pquentin added a commit that referenced this pull request Aug 29, 2025
* Enforce doc_id tag on public APIs

* Fix tests

* Add doc_id test

(cherry picked from commit 01182b0)

# Conflicts:
#	output/schema/schema.json
#	specification/_doc_ids/table.csv
#	specification/_global/knn_search/_types/Knn.ts
#	specification/indices/delete_data_stream_options/IndicesDeleteDataStreamOptionsRequest.ts
#	specification/indices/get_data_stream_options/IndicesGetDataStreamOptionsRequest.ts
#	specification/indices/put_data_stream_options/IndicesPutDataStreamOptionsRequest.ts
#	specification/indices/unfreeze/IndicesUnfreezeResponse.ts
@pquentin
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.19

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Aug 29, 2025
* Enforce doc_id tag on public APIs

* Fix tests

* Add doc_id test

(cherry picked from commit 01182b0)

# Conflicts:
#	output/schema/schema.json
#	specification/_doc_ids/table.csv
#	specification/_global/knn_search/_types/Knn.ts
#	specification/indices/delete_data_stream_options/IndicesDeleteDataStreamOptionsRequest.ts
#	specification/indices/get_data_stream_options/IndicesGetDataStreamOptionsRequest.ts
#	specification/indices/put_data_stream_options/IndicesPutDataStreamOptionsRequest.ts
#	specification/indices/unfreeze/IndicesUnfreezeResponse.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants