-
Notifications
You must be signed in to change notification settings - Fork 115
Enforce doc_id tag on public APIs #5198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5198-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 01182b0b19cd19a33ef51790d68c82604e51c4fa
# Push it to GitHub
git push --set-upstream origin backport-5198-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-5198-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 01182b0b19cd19a33ef51790d68c82604e51c4fa
# Push it to GitHub
git push --set-upstream origin backport-5198-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-5198-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 01182b0b19cd19a33ef51790d68c82604e51c4fa
# Push it to GitHub
git push --set-upstream origin backport-5198-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0Then, create a pull request where the |
* Enforce doc_id tag on public APIs * Fix tests * Add doc_id test (cherry picked from commit 01182b0)
* Enforce doc_id tag on public APIs * Fix tests * Add doc_id test (cherry picked from commit 01182b0) Co-authored-by: Quentin Pradet <[email protected]>
* Enforce doc_id tag on public APIs * Fix tests * Add doc_id test (cherry picked from commit 01182b0) # Conflicts: # output/schema/schema.json # specification/_doc_ids/table.csv # specification/esql/get_query/GetQueryRequest.ts # specification/esql/list_queries/ListQueriesRequest.ts # specification/indices/delete_data_stream_options/IndicesDeleteDataStreamOptionsRequest.ts # specification/indices/get_data_stream_options/IndicesGetDataStreamOptionsRequest.ts # specification/indices/put_data_stream_options/IndicesPutDataStreamOptionsRequest.ts
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
* Enforce doc_id tag on public APIs * Fix tests * Add doc_id test (cherry picked from commit 01182b0) # Conflicts: # output/schema/schema.json # specification/_doc_ids/table.csv # specification/esql/get_query/GetQueryRequest.ts # specification/esql/list_queries/ListQueriesRequest.ts # specification/indices/delete_data_stream_options/IndicesDeleteDataStreamOptionsRequest.ts # specification/indices/get_data_stream_options/IndicesGetDataStreamOptionsRequest.ts # specification/indices/put_data_stream_options/IndicesPutDataStreamOptionsRequest.ts
* Enforce doc_id tag on public APIs * Fix tests * Add doc_id test (cherry picked from commit 01182b0) # Conflicts: # output/schema/schema.json # specification/_doc_ids/table.csv # specification/_global/knn_search/_types/Knn.ts # specification/indices/delete_data_stream_options/IndicesDeleteDataStreamOptionsRequest.ts # specification/indices/get_data_stream_options/IndicesGetDataStreamOptionsRequest.ts # specification/indices/put_data_stream_options/IndicesPutDataStreamOptionsRequest.ts # specification/indices/unfreeze/IndicesUnfreezeResponse.ts
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
* Enforce doc_id tag on public APIs * Fix tests * Add doc_id test (cherry picked from commit 01182b0) # Conflicts: # output/schema/schema.json # specification/_doc_ids/table.csv # specification/_global/knn_search/_types/Knn.ts # specification/indices/delete_data_stream_options/IndicesDeleteDataStreamOptionsRequest.ts # specification/indices/get_data_stream_options/IndicesGetDataStreamOptionsRequest.ts # specification/indices/put_data_stream_options/IndicesPutDataStreamOptionsRequest.ts # specification/indices/unfreeze/IndicesUnfreezeResponse.ts
This came up when working on elastic/elasticsearch#133386.