Skip to content

Conversation

@pquentin
Copy link
Member

@pquentin pquentin commented Aug 29, 2025

shutdown and autoscaling APIs are private in rest-api-spec, and were never meant to receive public usage. This change means they will disappear from documentation and language clients.

See elastic/elasticsearch#77493 (comment) where it was done in the rest-api-spec. We missed it in the Elasticsearch specification.

I'm not sure about the 8.19 backport.

@github-actions
Copy link
Contributor

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin changed the title Mark autoscaling APIs as private Mark cloud-only APIs as private Aug 29, 2025
@Anaethelion
Copy link
Contributor

I'm not sure about the 8.19 backport.

I'd say no to the backport.

Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I checked the JS generator and it does not appear to omit private APIs from the client, which may be important for Kibana.

@pquentin pquentin merged commit 98ec7ac into main Sep 8, 2025
10 of 11 checks passed
@pquentin pquentin deleted the autoscaling-apis-private branch September 8, 2025 06:41
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5235-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 98ec7ac24c4fbb1acb2abccf8325251ad4a1e4c6
# Push it to GitHub
git push --set-upstream origin backport-5235-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-5235-to-8.19.

pquentin added a commit that referenced this pull request Sep 8, 2025
(cherry picked from commit 98ec7ac)

# Conflicts:
#	output/openapi/elasticsearch-openapi.json
@pquentin
Copy link
Member Author

pquentin commented Sep 8, 2025

💚 All backports created successfully

Status Branch Result
8.19

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Sep 9, 2025
(cherry picked from commit 98ec7ac)

# Conflicts:
#	output/openapi/elasticsearch-openapi.json
lcawl pushed a commit that referenced this pull request Sep 18, 2025
lcawl pushed a commit that referenced this pull request Sep 18, 2025
@lcawl
Copy link
Contributor

lcawl commented Sep 18, 2025

💚 All backports created successfully

Status Branch Result
9.1
9.0

Questions ?

Please refer to the Backport tool documentation

@lcawl
Copy link
Contributor

lcawl commented Sep 18, 2025

This information was still appearing in the v9 docs, so I created the backports for v9.1 and v9.0 branches.

pquentin added a commit that referenced this pull request Sep 19, 2025
(cherry picked from commit 98ec7ac)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Sep 19, 2025
(cherry picked from commit 98ec7ac)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Sep 19, 2025
pquentin added a commit that referenced this pull request Sep 19, 2025
pquentin added a commit that referenced this pull request Sep 19, 2025
pquentin added a commit that referenced this pull request Sep 22, 2025
pquentin added a commit that referenced this pull request Sep 22, 2025
pquentin added a commit that referenced this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants