Skip to content

Conversation

@pquentin
Copy link
Member

@pquentin pquentin commented Sep 2, 2025

Reverts #1144

I spent hours getting Kibana type checking to work with this change, but it's just too much work:

  • There are thousands of tests that use mock search responses, they all need to be changed to _score, max_score or both.
  • Some code is taking advantage of the fact that the get response and search hits have the same required fields.
  • Some Kibana types are extending the search hits.

Since making those types required offers little benefit, let's revert the change.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin added the skip-backport This pull request should not be backported label Sep 2, 2025
@pquentin pquentin requested review from l-trotta and swallez September 2, 2025 10:35
@pquentin pquentin merged commit 572531f into main Sep 2, 2025
8 checks passed
@pquentin pquentin deleted the revert-1144-make-score-required branch September 2, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-backport This pull request should not be backported specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants