Skip to content

Conversation

lukewhiting
Copy link
Contributor

@lukewhiting lukewhiting commented Sep 4, 2025

This adds the new logs streams endpoints to the spec.

This will need backporting to 9.1 as that's when these endpoints were added.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the new logs streams endpoints to the Elasticsearch specification, including API definitions for enabling, disabling, and checking the status of logs streams functionality.

  • Adds TypeScript interface definitions for three new logs streams endpoints
  • Includes comprehensive example files for requests and responses with various status codes
  • Updates the tsconfig.json to include the new streams module path mapping

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
specification/tsconfig.json Adds path mapping for the new @streams/* module
specification/streams/status/StreamsStatusRequest.ts Defines the GET _streams/status endpoint interface
specification/streams/status/StreamsStatusResponse.ts Defines response structure for streams status endpoint
specification/streams/logs_enable/StreamsLogsEnableRequest.ts Defines the POST _streams/logs/_enable endpoint interface
specification/streams/logs_enable/StreamsLogsEnableResponse.ts Defines response structure for logs enable endpoint
specification/streams/logs_disable/StreamsLogsDisableRequest.ts Defines the POST _streams/logs/_disable endpoint interface
specification/streams/logs_disable/StreamsLogsDisableResponse.ts Defines response structure for logs disable endpoint
Various example files Provides request/response examples for all endpoints including error cases
docs/add-new-api.md Minor grammar improvement in documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

github-actions bot commented Sep 5, 2025

Following you can find the validation changes against the target branch for the APIs.

API Status Request Response
streams.logs_disable 🟠 → ⚪ Missing type → Missing test Missing type → Missing test
streams.logs_enable 🟠 → ⚪ Missing type → Missing test Missing type → Missing test
streams.status 🟠 → ⚪ Missing type → Missing test Missing type → Missing test

You can validate these APIs yourself by using the make validate target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants