-
Notifications
You must be signed in to change notification settings - Fork 109
Add spec and docs for new logs streams endpoints #5258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the new logs streams endpoints to the Elasticsearch specification, including API definitions for enabling, disabling, and checking the status of logs streams functionality.
- Adds TypeScript interface definitions for three new logs streams endpoints
- Includes comprehensive example files for requests and responses with various status codes
- Updates the tsconfig.json to include the new streams module path mapping
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
specification/tsconfig.json | Adds path mapping for the new @streams/* module |
specification/streams/status/StreamsStatusRequest.ts | Defines the GET _streams/status endpoint interface |
specification/streams/status/StreamsStatusResponse.ts | Defines response structure for streams status endpoint |
specification/streams/logs_enable/StreamsLogsEnableRequest.ts | Defines the POST _streams/logs/_enable endpoint interface |
specification/streams/logs_enable/StreamsLogsEnableResponse.ts | Defines response structure for logs enable endpoint |
specification/streams/logs_disable/StreamsLogsDisableRequest.ts | Defines the POST _streams/logs/_disable endpoint interface |
specification/streams/logs_disable/StreamsLogsDisableResponse.ts | Defines response structure for logs disable endpoint |
Various example files | Provides request/response examples for all endpoints including error cases |
docs/add-new-api.md | Minor grammar improvement in documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
specification/streams/status/examples/200_response/GetStreamsStatusResponseExample1.yaml
Outdated
Show resolved
Hide resolved
…tatusResponseExample1.yaml Co-authored-by: Copilot <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]>
Following you can find the validation changes against the target branch for the APIs.
You can validate these APIs yourself by using the |
This adds the new logs streams endpoints to the spec.
This will need backporting to 9.1 as that's when these endpoints were added.