Skip to content

Conversation

@kosabogi
Copy link
Contributor

@kosabogi kosabogi commented Sep 8, 2025

As per this issue, the descriptions for the frequency parameter were missing from the ML anomaly detection APIs.

This issue fixed the parameter descriptions in the request bodies, but the response descriptions were still missing.

After discussing with @l-trotta, we decided to add them manually. This PR adds the missing descriptions for the following API responses:

  • Create an anomaly detection job
  • Preview a datafeed
  • Update an anomaly detection job
  • Update a datafeed

@kosabogi kosabogi requested a review from l-trotta September 8, 2025 09:52
@kosabogi kosabogi requested review from a team as code owners September 8, 2025 09:52
@kosabogi kosabogi changed the title Adds description for the 'frequency' parameter to the Datafeed.ts file Adds description for the 'frequency' parameter in responses Sep 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@kosabogi kosabogi merged commit 742151e into main Sep 8, 2025
8 checks passed
@kosabogi kosabogi deleted the frequency-description branch September 8, 2025 10:18
github-actions bot pushed a commit that referenced this pull request Sep 8, 2025
* Adds frequency parameter description to the Datafeed.ts file

* Adds missing description

* Fixes code style errpr

(cherry picked from commit 742151e)
github-actions bot pushed a commit that referenced this pull request Sep 8, 2025
* Adds frequency parameter description to the Datafeed.ts file

* Adds missing description

* Fixes code style errpr

(cherry picked from commit 742151e)
pquentin added a commit that referenced this pull request Sep 11, 2025
…5268)

* Adds frequency parameter description to the Datafeed.ts file

* Adds missing description

* Fixes code style errpr

(cherry picked from commit 742151e)

Co-authored-by: kosabogi <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]>
pquentin pushed a commit that referenced this pull request Sep 11, 2025
…5267)

* Adds frequency parameter description to the Datafeed.ts file

* Adds missing description

* Fixes code style errpr

(cherry picked from commit 742151e)

Co-authored-by: kosabogi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants