-
Notifications
You must be signed in to change notification settings - Fork 114
Remove '| string' in query parameters #5312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Refer to the description for the `overall_score` query parameter. | ||
*/ | ||
overall_score?: double | string | ||
overall_score?: double |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this one isn't a query parameter, it feels like a straight-up bug.
Following you can find the validation changes against the target branch for the API.
You can validate this API yourself by using the |
At least I have the reason why this was done: YAML tests!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ML change LGTM
Merging! There's one failure left on |
The
| string
isn't meaningful in those two cases and this helps #5215. I'm skipping backports since this is a breaking change, though.