-
Notifications
You must be signed in to change notification settings - Fork 116
Cache API validation results #5376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Following you can find the validation changes against the target branch for the APIs.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL Github Actions has a cache service!
LGTM.
Also use restore-keys
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5376-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bd811dc9f6f29f58cc4b4910bb7a0c6ef62569c5
# Push it to GitHub
git push --set-upstream origin backport-5376-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-5376-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bd811dc9f6f29f58cc4b4910bb7a0c6ef62569c5
# Push it to GitHub
git push --set-upstream origin backport-5376-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0Then, create a pull request where the |
* Generate API validation report * Fix path and add cache * Add cache/restore steps * Test with main * Prepare for merge * Use single workflow Also use restore-keys * Remove correct file * Fix zizmor issues * Remove contents: read since the repo is public (cherry picked from commit bd811dc)
* Generate API validation report * Fix path and add cache * Add cache/restore steps * Test with main * Prepare for merge * Use single workflow Also use restore-keys * Remove correct file * Fix zizmor issues * Remove contents: read since the repo is public (cherry picked from commit bd811dc)
* Generate API validation report * Fix path and add cache * Add cache/restore steps * Test with main * Prepare for merge * Use single workflow Also use restore-keys * Remove correct file * Fix zizmor issues * Remove contents: read since the repo is public (cherry picked from commit bd811dc)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
* Cache API validation results (#5376) * Generate API validation report * Fix path and add cache * Add cache/restore steps * Test with main * Prepare for merge * Use single workflow Also use restore-keys * Remove correct file * Fix zizmor issues * Remove contents: read since the repo is public (cherry picked from commit bd811dc) * Apply changes from main
* Cache API validation results (#5376) * Generate API validation report * Fix path and add cache * Add cache/restore steps * Test with main * Prepare for merge * Use single workflow Also use restore-keys * Remove correct file * Fix zizmor issues * Remove contents: read since the repo is public (cherry picked from commit bd811dc) * Apply changes from main
* Cache API validation results (#5376) * Generate API validation report * Fix path and add cache * Add cache/restore steps * Test with main * Prepare for merge * Use single workflow Also use restore-keys * Remove correct file * Fix zizmor issues * Remove contents: read since the repo is public (cherry picked from commit bd811dc) * Port changes applied to main --------- Co-authored-by: Quentin Pradet <[email protected]>
While #5341 is a great improvement, we ran into a problem where it showed seemingly unrelated changes. This happened when the target branch contained commits that were not yet tested by the daily clients-flight-recorder runs.
This PR instead caches those runs to get fresher results.