Skip to content

Conversation

@pquentin
Copy link
Member

@pquentin pquentin commented Sep 30, 2025

While #5341 is a great improvement, we ran into a problem where it showed seemingly unrelated changes. This happened when the target branch contained commits that were not yet tested by the daily clients-flight-recorder runs.

This PR instead caches those runs to get fresher results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025

Following you can find the validation changes against the target branch for the APIs.

API Status Request Response
indices.create 🔴 1362/1402 → 1364/1402 1402/1402
sql.translate 🔴 → 🟢 1/1 0/1 → 1/1

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin marked this pull request as ready for review September 30, 2025 12:51
@pquentin pquentin requested a review from a team as a code owner September 30, 2025 12:51
Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL Github Actions has a cache service!

LGTM.

@pquentin pquentin merged commit bd811dc into main Oct 1, 2025
8 checks passed
@pquentin pquentin deleted the generate-report branch October 1, 2025 11:02
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5376-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bd811dc9f6f29f58cc4b4910bb7a0c6ef62569c5
# Push it to GitHub
git push --set-upstream origin backport-5376-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-5376-to-8.19.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

The backport to 9.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-5376-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bd811dc9f6f29f58cc4b4910bb7a0c6ef62569c5
# Push it to GitHub
git push --set-upstream origin backport-5376-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0

Then, create a pull request where the base branch is 9.0 and the compare/head branch is backport-5376-to-9.0.

github-actions bot pushed a commit that referenced this pull request Oct 1, 2025
* Generate API validation report

* Fix path and add cache

* Add cache/restore steps

* Test with main

* Prepare for merge

* Use single workflow

Also use restore-keys

* Remove correct file

* Fix zizmor issues

* Remove contents: read since the repo is public

(cherry picked from commit bd811dc)
pquentin added a commit that referenced this pull request Oct 1, 2025
* Generate API validation report

* Fix path and add cache

* Add cache/restore steps

* Test with main

* Prepare for merge

* Use single workflow

Also use restore-keys

* Remove correct file

* Fix zizmor issues

* Remove contents: read since the repo is public

(cherry picked from commit bd811dc)
pquentin added a commit that referenced this pull request Oct 1, 2025
* Generate API validation report

* Fix path and add cache

* Add cache/restore steps

* Test with main

* Prepare for merge

* Use single workflow

Also use restore-keys

* Remove correct file

* Fix zizmor issues

* Remove contents: read since the repo is public

(cherry picked from commit bd811dc)
@pquentin
Copy link
Member Author

pquentin commented Oct 1, 2025

💚 All backports created successfully

Status Branch Result
9.0
8.19

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Oct 1, 2025
* Cache API validation results (#5376)

* Generate API validation report

* Fix path and add cache

* Add cache/restore steps

* Test with main

* Prepare for merge

* Use single workflow

Also use restore-keys

* Remove correct file

* Fix zizmor issues

* Remove contents: read since the repo is public

(cherry picked from commit bd811dc)

* Apply changes from main
pquentin added a commit that referenced this pull request Oct 1, 2025
* Cache API validation results (#5376)

* Generate API validation report

* Fix path and add cache

* Add cache/restore steps

* Test with main

* Prepare for merge

* Use single workflow

Also use restore-keys

* Remove correct file

* Fix zizmor issues

* Remove contents: read since the repo is public

(cherry picked from commit bd811dc)

* Apply changes from main
pquentin added a commit that referenced this pull request Oct 1, 2025
* Cache API validation results (#5376)

* Generate API validation report

* Fix path and add cache

* Add cache/restore steps

* Test with main

* Prepare for merge

* Use single workflow

Also use restore-keys

* Remove correct file

* Fix zizmor issues

* Remove contents: read since the repo is public

(cherry picked from commit bd811dc)

* Port changes applied to main

---------

Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants