Skip to content

Adds sparse_vector index options to semantic_text index specification #5386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2025
Merged

Adds sparse_vector index options to semantic_text index specification #5386

merged 2 commits into from
Oct 2, 2025

Conversation

markjhoy
Copy link
Contributor

@markjhoy markjhoy commented Oct 1, 2025

Adds the missing sparse_vector property to the semantic_text index options. This functionality was added via this PR for Elasticsearch.

@markjhoy markjhoy requested review from a team and pquentin October 1, 2025 12:56
@markjhoy markjhoy mentioned this pull request Oct 1, 2025
Open
9 tasks
@markjhoy markjhoy added the skip-backport This pull request should not be backported label Oct 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025 •
edited
Loading

Following you can find the validation changes against the target branch for the APIs.

API Status Request Response
indices.create 🔴 1339/1372 → 1342/1372 1372/1372
indices.put_mapping 🔴 138/145 → 139/145 148/148

You can validate these APIs yourself by using the make validate target.

kderusso
kderusso reviewed Oct 1, 2025
View reviewed changes
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pquentin pquentin added backport 9.2 and removed skip-backport This pull request should not be backported labels Oct 2, 2025
@pquentin pquentin merged commit ba6c2fb into main Oct 2, 2025
11 checks passed
@pquentin pquentin deleted the markjhoy/add_semantic_text_sparse_vector_options branch October 2, 2025 12:02
github-actions bot pushed a commit that referenced this pull request Oct 2, 2025
@markjhoy @pquentin @github-actions
adds sparse_vector to semantic_text index options (#5386)
68daef0 
Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit ba6c2fb)
@github-actions github-actions bot mentioned this pull request Oct 2, 2025
Merged
pquentin added a commit that referenced this pull request Oct 2, 2025
@github-actions @markjhoy @pquentin
adds sparse_vector to semantic_text index options (#5386) (#5396)
a0d4303 
(cherry picked from commit ba6c2fb)

Co-authored-by: Mark J. Hoy <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kderusso kderusso kderusso left review comments

@pquentin pquentin pquentin approved these changes

Assignees

No one assigned

Labels

backport 9.2 specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markjhoy @pquentin @kderusso