Skip to content

Conversation

@l-trotta
Copy link
Contributor

@l-trotta l-trotta commented Oct 6, 2025

Field _source should be the same type as in SearchRequest, so a SearchConfig. server code

This is a breaking change, and currently it partially works (when the value of _source is a boolean) (thanks @pquentin!)

@l-trotta l-trotta added the skip-backport This pull request should not be backported label Oct 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Following you can find the validation changes against the target branch for the API.

API Status Request Response
reindex 🔴 → 🟢 20/21 → 21/21 20/20

You can validate this API yourself by using the make validate target.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@l-trotta l-trotta merged commit 45b93f8 into main Oct 7, 2025
10 checks passed
@l-trotta l-trotta deleted the reindex-fix branch October 7, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-backport This pull request should not be backported specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants