Remove top-level size from ReindexRequest

[PeteGillinElastic]

This was removed from ES in 8.0.0 (see
elastic/elasticsearch#43373).

[github-actions]

Following you can find the validation changes against the target branch for the APIs.

API	Status	Request	Response
bulk	🟢	537/537 → 538/538	555/555 → 556/556
esql.query	🟢	358/358 → 359/359	0/0
indices.create	🔴	1357/1381 → 1358/1382	1381/1381 → 1382/1382

You can validate these APIs yourself by using the make validate target.

[pquentin]

Thanks! Is it silently accepted, or does the server refuse it? I'd like to feel less bad about the backports :)

[PeteGillinElastic]

Thanks! Is it silently accepted, or does the server refuse it? I'd like to feel less bad about the backports :)

The server has thrown an error since 8.0.0, based on my reading of the PRs.

[PeteGillinElastic]

Hi @pquentin, can you advise on the backporting here? I think this falls under

If the API is usable, but fix is on the request side -> no backport, unless the API is partially usable and the fix unlocks a missing feature that has no workaround

because the API is absolutely usable, the only issue is that clients may provide an option that would result in a 400. But I may be interpreting that wrongly.

[pquentin]

Since this option is unusable, backporting is fine!

[PeteGillinElastic]

Okay, backporting is also fine with me.

Are you okay to approve this PR, or should I ask someone from my team?

[pquentin]

Thanks! LGTM.

[github-actions]

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5471-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 263280a58bdaa8ee1061eb407bf2280bd6547207
# Push it to GitHub
git push --set-upstream origin backport-5471-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-5471-to-8.19.

[PeteGillinElastic]

Do backports in this repo need review?

• [Backport 9.2] Remove top-level size from ReindexRequest #5480
• [Backport 8.19] Remove top-level size from ReindexRequest #5481