-
Couldn't load subscription status.
- Fork 115
Clarifies that the docs.count field in the _cat/indices API includes hidden nested documents.
#5484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarifies that the docs.count field in the _cat/indices API includes hidden nested documents.
#5484
Conversation
|
Hi @leemthompo @kderusso, I've reviewed the CatIndicesRequest.ts file and noticed that the API-level documentation already includes the necessary clarification about nested documents: /**
* These metrics are retrieved directly from Lucene, which Elasticsearch uses internally
* to power indexing and search. As a result, all document counts include hidden nested documents.
* To get an accurate count of Elasticsearch documents, use the cat count or count APIs.
*/These lines are already present in the main branch at lines 39-40 of the JSDoc comment for the Therefore, I've only updated IndicesRecord.ts to add field-level documentation for the The documentation is now complete with:
Please let me know if you'd like me to make any additional changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing this! I left a couple questions/suggestions.
Co-authored-by: Mike Pellegrini <[email protected]>
|
@mridula-s109 not sure if I shared this already, but if you want to preview your changes (or if you're curious about the the API specs workflow) you can check out https://www.elastic.co/docs/contribute-docs/api-docs/quickstart |
Unfortunately, need to make PRs from branches in this repo :/ |
|
To get CI passing, can you please send your pull request from a branch? As mentioned in CONTRIBUTING.md. I realize that it's confusing as it's the opposite of Elasticsearch, sorry. |
|
Thanks everyone for the reviews and feedback! 👋 As suggested, I’ve recreated this PR from a branch within the Elastic repository to enable CI validation and unblock merging. I’ve carried forward all the same changes (field-level clarification for docs.count in _cat/indices) and incorporated review feedback. Closing this one in favor of the new PR. |
Summary
Clarifies that the
docs.countfield in the_cat/indicesAPI includes hidden nested documents, which can lead to higher counts than expected when using field types likesemantic_text.Changes
docs.countinCatIndicesRequest.tsto explicitly state that it includes nested documents_countor_cat/countAPIs for logical document countRelated Issues
Fixes #127354
Related PRs