-
Notifications
You must be signed in to change notification settings - Fork 115
Adds weight
parameter type definition for RRF retrievers.
#5502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mridula-s109
wants to merge
4
commits into
main
Choose a base branch
from
add-weighted-rrf-retriever-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18
−2
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -133,9 +133,25 @@ export class KnnRetriever extends RetrieverBase { | |
rescore_vector?: RescoreVector | ||
} | ||
|
||
/** | ||
* Wraps a retriever with an optional weight for RRF scoring. | ||
*/ | ||
export class RRFRetrieverComponent { | ||
/** The nested retriever configuration. */ | ||
retriever: RetrieverContainer | ||
/** Weight multiplier for this retriever's contribution to the RRF score. Higher values increase influence. Defaults to 1.0 if not specified. Must be non-negative. */ | ||
weight?: float | ||
} | ||
|
||
/** | ||
* Either a direct RetrieverContainer (backward compatible) or an RRFRetrieverComponent with weight. | ||
* @codegen_names retriever, weighted | ||
*/ | ||
export type RRFRetrieverEntry = RetrieverContainer | RRFRetrieverComponent | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 that name fits better |
||
|
||
export class RRFRetriever extends RetrieverBase { | ||
/** A list of child retrievers to specify which sets of returned top documents will have the RRF formula applied to them. */ | ||
retrievers: RetrieverContainer[] | ||
/** A list of child retrievers to specify which sets of returned top documents will have the RRF formula applied to them. Each retriever can optionally include a weight parameter. */ | ||
retrievers: RRFRetrieverEntry[] | ||
/** This value determines how much influence documents in individual result sets per query have over the final ranked result set. */ | ||
rank_constant?: integer | ||
/** This value determines the size of the individual result sets per query. */ | ||
|
@@ -144,6 +160,8 @@ export class RRFRetriever extends RetrieverBase { | |
fields?: string[] | ||
} | ||
|
||
|
||
|
||
export class TextSimilarityReranker extends RetrieverBase { | ||
/** The nested retriever which will produce the first-level results, that will later be used for reranking. */ | ||
retriever: RetrieverContainer | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/nit: we should also add the @server_default tag as a machine readable alternative to mentioning the default value in the doc string.